csky/cpu: Make sure arch_cpu_idle_dead() doesn't return
authorJosh Poimboeuf <jpoimboe@kernel.org>
Tue, 14 Feb 2023 07:05:39 +0000 (23:05 -0800)
committerJosh Poimboeuf <jpoimboe@kernel.org>
Mon, 6 Mar 2023 23:34:05 +0000 (15:34 -0800)
arch_cpu_idle_dead() doesn't return.  Make that more explicit with a
BUG().

BUG() is preferable to unreachable() because BUG() is a more explicit
failure mode and avoids undefined behavior like falling off the edge of
the function into whatever code happens to be next.

Acked-by: Guo Ren <guoren@kernel.org>
Link: https://lore.kernel.org/r/1e9ecc3d248e82973e80bc336fc9f97e3ba2708d.1676358308.git.jpoimboe@kernel.org
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
arch/csky/kernel/smp.c

index b45d107..0ec20ef 100644 (file)
@@ -317,5 +317,7 @@ void arch_cpu_idle_dead(void)
                "jmpi   csky_start_secondary"
                :
                : "r" (secondary_stack));
+
+       BUG();
 }
 #endif