drm/amd: Require CONFIG_HOTPLUG_PCI_PCIE for BOCO
authorMario Limonciello <mario.limonciello@amd.com>
Wed, 11 Dec 2024 15:56:01 +0000 (09:56 -0600)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 18 Dec 2024 17:15:40 +0000 (12:15 -0500)
If the kernel hasn't been compiled with PCIe hotplug support this
can lead to problems with dGPUs that use BOCO because they effectively
drop off the bus.

To prevent issues, disable BOCO support when compiled without PCIe hotplug.

Reported-by: Gabriel Marcano <gabemarcano@yahoo.com>
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/1707#note_2696862
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Link: https://lore.kernel.org/r/20241211155601.3585256-1-superm1@kernel.org
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

index e22fc7a..36053b3 100644 (file)
@@ -419,6 +419,9 @@ bool amdgpu_device_supports_boco(struct drm_device *dev)
 {
        struct amdgpu_device *adev = drm_to_adev(dev);
 
+       if (!IS_ENABLED(CONFIG_HOTPLUG_PCI_PCIE))
+               return false;
+
        if (adev->has_pr3 ||
            ((adev->flags & AMD_IS_PX) && amdgpu_is_atpx_hybrid()))
                return true;