media: amphion: no need to check return value of debugfs_create functions
authorLv Ruyi <lv.ruyi@zte.com.cn>
Fri, 22 Apr 2022 02:12:46 +0000 (04:12 +0200)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Fri, 13 May 2022 09:02:20 +0000 (11:02 +0200)
When calling debugfs functions, there is no need to ever check the
return value. The function can work or not, but the code logic should
never do something different based on this.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/platform/amphion/vpu_dbg.c

index 376196b..da62bd7 100644 (file)
@@ -413,10 +413,6 @@ int vpu_inst_create_dbgfs_file(struct vpu_inst *inst)
                                            vpu->debugfs,
                                            inst,
                                            &vpu_dbg_inst_fops);
-       if (!inst->debugfs) {
-               dev_err(inst->dev, "vpu create debugfs %s fail\n", name);
-               return -EINVAL;
-       }
 
        return 0;
 }
@@ -451,10 +447,6 @@ int vpu_core_create_dbgfs_file(struct vpu_core *core)
                                                    vpu->debugfs,
                                                    core,
                                                    &vpu_dbg_core_fops);
-               if (!core->debugfs) {
-                       dev_err(core->dev, "vpu create debugfs %s fail\n", name);
-                       return -EINVAL;
-               }
        }
        if (!core->debugfs_fwlog) {
                scnprintf(name, sizeof(name), "fwlog.%d", core->id);
@@ -463,10 +455,6 @@ int vpu_core_create_dbgfs_file(struct vpu_core *core)
                                                          vpu->debugfs,
                                                          core,
                                                          &vpu_dbg_fwlog_fops);
-               if (!core->debugfs_fwlog) {
-                       dev_err(core->dev, "vpu create debugfs %s fail\n", name);
-                       return -EINVAL;
-               }
        }
 
        return 0;