net: kcm: kcmproc.c: Fix RCU list suspicious usage warning
authorMadhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
Mon, 16 Mar 2020 17:13:52 +0000 (22:43 +0530)
committerDavid S. Miller <davem@davemloft.net>
Tue, 17 Mar 2020 00:14:02 +0000 (17:14 -0700)
This path fixes the suspicious RCU usage warning reported by
kernel test robot.

net/kcm/kcmproc.c:#RCU-list_traversed_in_non-reader_section

There is no need to use list_for_each_entry_rcu() in
kcm_stats_seq_show() as the list is always traversed under
knet->mutex held.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/kcm/kcmproc.c

index 370da2f..25c1007 100644 (file)
@@ -261,7 +261,7 @@ static int kcm_stats_seq_show(struct seq_file *seq, void *v)
        aggregate_strp_stats(&knet->aggregate_strp_stats,
                             &strp_stats);
 
-       list_for_each_entry_rcu(mux, &knet->mux_list, kcm_mux_list) {
+       list_for_each_entry(mux, &knet->mux_list, kcm_mux_list) {
                spin_lock_bh(&mux->lock);
                aggregate_mux_stats(&mux->stats, &mux_stats);
                aggregate_psock_stats(&mux->aggregate_psock_stats,