nfc: st-nci: drop ftrace-like debugging messages
authorKrzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Mon, 31 May 2021 07:39:01 +0000 (09:39 +0200)
committerJakub Kicinski <kuba@kernel.org>
Tue, 1 Jun 2021 04:32:37 +0000 (21:32 -0700)
Now that the kernel has ftrace, any debugging calls that just do "made
it to this function!" and "leaving this function!" can be removed.
Better to use standard debugging tools.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Link: https://lore.kernel.org/r/20210531073902.7111-6-krzysztof.kozlowski@canonical.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/nfc/st-nci/i2c.c
drivers/nfc/st-nci/se.c
drivers/nfc/st-nci/spi.c

index 663d1cc..4698140 100644 (file)
@@ -206,9 +206,6 @@ static int st_nci_i2c_probe(struct i2c_client *client,
        struct st_nci_i2c_phy *phy;
        int r;
 
-       dev_dbg(&client->dev, "%s\n", __func__);
-       dev_dbg(&client->dev, "IRQ: %d\n", client->irq);
-
        if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) {
                nfc_err(&client->dev, "Need I2C_FUNC_I2C\n");
                return -ENODEV;
@@ -261,8 +258,6 @@ static int st_nci_i2c_remove(struct i2c_client *client)
 {
        struct st_nci_i2c_phy *phy = i2c_get_clientdata(client);
 
-       dev_dbg(&client->dev, "%s\n", __func__);
-
        ndlc_remove(phy->ndlc);
 
        return 0;
index 8657e02..5fd89f7 100644 (file)
@@ -470,8 +470,6 @@ int st_nci_disable_se(struct nci_dev *ndev, u32 se_idx)
 {
        int r;
 
-       pr_debug("st_nci_disable_se\n");
-
        /*
         * According to upper layer, se_idx == NFC_SE_UICC when
         * info->se_info.se_status->is_uicc_enable is true should never happen
@@ -496,8 +494,6 @@ int st_nci_enable_se(struct nci_dev *ndev, u32 se_idx)
 {
        int r;
 
-       pr_debug("st_nci_enable_se\n");
-
        /*
         * According to upper layer, se_idx == NFC_SE_UICC when
         * info->se_info.se_status->is_uicc_enable is true should never happen.
@@ -602,8 +598,6 @@ int st_nci_discover_se(struct nci_dev *ndev)
        int se_count = 0;
        struct st_nci_info *info = nci_get_drvdata(ndev);
 
-       pr_debug("st_nci_discover_se\n");
-
        r = st_nci_hci_network_init(ndev);
        if (r != 0)
                return r;
index 5f1a217..250d56f 100644 (file)
@@ -216,9 +216,6 @@ static int st_nci_spi_probe(struct spi_device *dev)
        struct st_nci_spi_phy *phy;
        int r;
 
-       dev_dbg(&dev->dev, "%s\n", __func__);
-       dev_dbg(&dev->dev, "IRQ: %d\n", dev->irq);
-
        /* Check SPI platform functionnalities */
        if (!dev) {
                pr_debug("%s: dev is NULL. Device is not accessible.\n",
@@ -274,8 +271,6 @@ static int st_nci_spi_remove(struct spi_device *dev)
 {
        struct st_nci_spi_phy *phy = spi_get_drvdata(dev);
 
-       dev_dbg(&dev->dev, "%s\n", __func__);
-
        ndlc_remove(phy->ndlc);
 
        return 0;