drm/i915/selftests: Fix wrong return value of perf_request_latency()
authorZhang Xiaoxu <zhangxiaoxu5@huawei.com>
Mon, 16 Nov 2020 14:35:40 +0000 (09:35 -0500)
committerChris Wilson <chris@chris-wilson.co.uk>
Mon, 16 Nov 2020 16:32:18 +0000 (16:32 +0000)
If intel context create failed, the perf_request_latency() will return 0
rather than error, because we doesn't initialize the return value.

Fixes: 25c26f18ea79 ("drm/i915/selftests: Measure dispatch latency")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20201116143540.3648870-1-zhangxiaoxu5@huawei.com
drivers/gpu/drm/i915/selftests/i915_request.c

index 480b3da..e424a6d 100644 (file)
@@ -2293,8 +2293,10 @@ static int perf_request_latency(void *arg)
                struct intel_context *ce;
 
                ce = intel_context_create(engine);
-               if (IS_ERR(ce))
+               if (IS_ERR(ce)) {
+                       err = PTR_ERR(ce);
                        goto out;
+               }
 
                err = intel_context_pin(ce);
                if (err) {