USB: serial: f81232: drop short control-transfer checks
authorJohan Hovold <johan@kernel.org>
Mon, 18 Jan 2021 11:14:25 +0000 (12:14 +0100)
committerJohan Hovold <johan@kernel.org>
Mon, 18 Jan 2021 13:26:46 +0000 (14:26 +0100)
There's no need to check for short control transfers when sending data
so remove the redundant sanity checks.

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
drivers/usb/serial/f81232.c

index 0c7eacc..6a8f391 100644 (file)
@@ -192,13 +192,9 @@ static int f81232_set_register(struct usb_serial_port *port, u16 reg, u8 val)
                                tmp,
                                sizeof(val),
                                USB_CTRL_SET_TIMEOUT);
-       if (status != sizeof(val)) {
+       if (status < 0) {
                dev_err(&port->dev, "%s failed status: %d\n", __func__, status);
-
-               if (status < 0)
-                       status = usb_translate_errors(status);
-               else
-                       status = -EIO;
+               status = usb_translate_errors(status);
        } else {
                status = 0;
        }
@@ -886,10 +882,6 @@ static int f81534a_ctrl_set_register(struct usb_interface *intf, u16 reg,
                        status = usb_translate_errors(status);
                        if (status == -EIO)
                                continue;
-               } else if (status != size) {
-                       /* Retry on short transfers */
-                       status = -EIO;
-                       continue;
                } else {
                        status = 0;
                }