ice: use min_t() to make code cleaner in ice_gnss
authorWan Jiabing <wanjiabing@vivo.com>
Mon, 21 Mar 2022 13:59:47 +0000 (21:59 +0800)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Thu, 5 May 2022 18:28:35 +0000 (11:28 -0700)
Fix the following coccicheck warning:
./drivers/net/ethernet/intel/ice/ice_gnss.c:79:26-27: WARNING opportunity for min()

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Tested-by: Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/ice/ice_gnss.c

index 35579cf..57586a2 100644 (file)
@@ -76,8 +76,7 @@ static void ice_gnss_read(struct kthread_work *work)
        for (i = 0; i < data_len; i += bytes_read) {
                u16 bytes_left = data_len - i;
 
-               bytes_read = bytes_left < ICE_MAX_I2C_DATA_SIZE ? bytes_left :
-                                         ICE_MAX_I2C_DATA_SIZE;
+               bytes_read = min_t(typeof(bytes_left), bytes_left, ICE_MAX_I2C_DATA_SIZE);
 
                err = ice_aq_read_i2c(hw, link_topo, ICE_GNSS_UBX_I2C_BUS_ADDR,
                                      cpu_to_le16(ICE_GNSS_UBX_EMPTY_DATA),