net/mlx5e: Do not recover from a non-fatal syndrome

For non-fatal syndromes like LOCAL_LENGTH_ERR, recovery shouldn't be
triggered. In these scenarios, the RQ is not actually in ERR state.
This misleads the recovery flow which assumes that the RQ is really in
error state and no more completions arrive, causing crashes on bad page
state.

Fixes: 8276ea1353a4 ("net/mlx5e: Report and recover from CQE with error on RQ")
Signed-off-by: Aya Levin <ayal@mellanox.com>
Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/health.h b/drivers/net/ethernet/mellanox/mlx5/core/en/health.h
index d3693fa..e54f70d 100644 (file)
--- a/drivers/net/ethernet/mellanox/mlx5/core/en/health.h
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en/health.h
@@ -10,8 +10,7 @@
 
 static inline bool cqe_syndrome_needs_recover(u8 syndrome)
 {
-       return syndrome == MLX5_CQE_SYNDROME_LOCAL_LENGTH_ERR ||
-              syndrome == MLX5_CQE_SYNDROME_LOCAL_QP_OP_ERR ||
+       return syndrome == MLX5_CQE_SYNDROME_LOCAL_QP_OP_ERR ||
               syndrome == MLX5_CQE_SYNDROME_LOCAL_PROT_ERR ||
               syndrome == MLX5_CQE_SYNDROME_WR_FLUSH_ERR;
 }