qed: devlink health: use retained error fmsg API

Drop unneeded error checking.

devlink_fmsg_*() family of functions is now retaining errors,
so there is no need to check for them after each call.

Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/qlogic/qed/qed_devlink.c b/drivers/net/ethernet/qlogic/qed/qed_devlink.c
index be5cc8b..dad8e61 100644 (file)
--- a/drivers/net/ethernet/qlogic/qed/qed_devlink.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_devlink.c
@@ -66,12 +66,12 @@ qed_fw_fatal_reporter_dump(struct devlink_health_reporter *reporter,
                return err;
        }
 
-       err = devlink_fmsg_binary_pair_put(fmsg, "dump_data",
-                                          p_dbg_data_buf, dbg_data_buf_size);
+       devlink_fmsg_binary_pair_put(fmsg, "dump_data", p_dbg_data_buf,
+                                    dbg_data_buf_size);
 
        vfree(p_dbg_data_buf);
 
-       return err;
+       return 0;
 }
 
 static int