dma-buf: fix S_IRUGO to 0444, block comments, func declaration

These warnings/errors are reported by checkpatch.
Fix them with minor changes to make it clean.
No other functional changes.

WARNING: Block comments use * on subsequent lines
+       /* only support discovering the end of the buffer,
+          but also allow SEEK_SET to maintain the idiomatic

WARNING: Block comments use a trailing */ on a separate line
+          SEEK_END(0), SEEK_CUR(0) pattern */

WARNING: Block comments use a trailing */ on a separate line
+        * before passing the sgt back to the exporter. */

ERROR: "foo * bar" should be "foo *bar"
+static struct sg_table * __map_dma_buf(struct dma_buf_attachment *attach,

WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
+       d = debugfs_create_file("bufinfo", S_IRUGO, dma_buf_debugfs_dir,

total: 1 errors, 4 warnings, 1746 lines checked

Signed-off-by: Pintu Kumar <quic_pintu@quicinc.com>
Acked-by: John Stultz <jstultz@google.com>
Signed-off-by: Sumit Semwal <sumit.semwal@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20241005180955.6523-1-quic_pintu@quicinc.com

diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c
index fbbb750..2472eb9 100644 (file)
--- a/drivers/dma-buf/dma-buf.c
+++ b/drivers/dma-buf/dma-buf.c
@@ -176,8 +176,9 @@ static loff_t dma_buf_llseek(struct file *file, loff_t offset, int whence)
        dmabuf = file->private_data;
 
        /* only support discovering the end of the buffer,
-          but also allow SEEK_SET to maintain the idiomatic
-          SEEK_END(0), SEEK_CUR(0) pattern */
+        * but also allow SEEK_SET to maintain the idiomatic
+        * SEEK_END(0), SEEK_CUR(0) pattern.
+        */
        if (whence == SEEK_END)
                base = dmabuf->size;
        else if (whence == SEEK_SET)
@@ -782,13 +783,14 @@ static void mangle_sg_table(struct sg_table *sg_table)
        /* To catch abuse of the underlying struct page by importers mix
         * up the bits, but take care to preserve the low SG_ bits to
         * not corrupt the sgt. The mixing is undone in __unmap_dma_buf
-        * before passing the sgt back to the exporter. */
+        * before passing the sgt back to the exporter.
+        */
        for_each_sgtable_sg(sg_table, sg, i)
                sg->page_link ^= ~0xffUL;
 #endif
 
 }
-static struct sg_table * __map_dma_buf(struct dma_buf_attachment *attach,
+static struct sg_table *__map_dma_buf(struct dma_buf_attachment *attach,
                                       enum dma_data_direction direction)
 {
        struct sg_table *sg_table;
@@ -1697,7 +1699,7 @@ static int dma_buf_init_debugfs(void)
 
        dma_buf_debugfs_dir = d;
 
-       d = debugfs_create_file("bufinfo", S_IRUGO, dma_buf_debugfs_dir,
+       d = debugfs_create_file("bufinfo", 0444, dma_buf_debugfs_dir,
                                NULL, &dma_buf_debug_fops);
        if (IS_ERR(d)) {
                pr_debug("dma_buf: debugfs: failed to create node bufinfo\n");