btrfs: remove trivial goto label in __extent_writepage()
authorOmar Sandoval <osandov@fb.com>
Tue, 3 Dec 2019 01:34:21 +0000 (17:34 -0800)
committerDavid Sterba <dsterba@suse.com>
Mon, 20 Jan 2020 15:40:54 +0000 (16:40 +0100)
Since 40f765805f08 ("Btrfs: split up __extent_writepage to lower stack
usage"), done_unlocked is simply a return 0. Get rid of it.
Mid-statement block returns don seem to make the code less readable here.

Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Omar Sandoval <osandov@fb.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/extent_io.c

index b2d0418..9475e81 100644 (file)
@@ -3596,7 +3596,7 @@ static int __extent_writepage(struct page *page, struct writeback_control *wbc,
        if (!epd->extent_locked) {
                ret = writepage_delalloc(inode, page, wbc, start, &nr_written);
                if (ret == 1)
-                       goto done_unlocked;
+                       return 0;
                if (ret)
                        goto done;
        }
@@ -3604,7 +3604,7 @@ static int __extent_writepage(struct page *page, struct writeback_control *wbc,
        ret = __extent_writepage_io(inode, page, wbc, epd,
                                    i_size, nr_written, &nr);
        if (ret == 1)
-               goto done_unlocked;
+               return 0;
 
 done:
        if (nr == 0) {
@@ -3619,9 +3619,6 @@ done:
        unlock_page(page);
        ASSERT(ret <= 0);
        return ret;
-
-done_unlocked:
-       return 0;
 }
 
 void wait_on_extent_buffer_writeback(struct extent_buffer *eb)