pwm: imx-tpm: Use dev_err_probe() to simplify error handling
authorAnson Huang <Anson.Huang@nxp.com>
Tue, 11 Aug 2020 06:24:30 +0000 (14:24 +0800)
committerThierry Reding <thierry.reding@gmail.com>
Thu, 17 Dec 2020 13:18:47 +0000 (14:18 +0100)
dev_err_probe() can reduce code size, uniform error handling and record the
defer probe reason etc., use it to simplify the code.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Acked-by: Lee Jones <lee.jones@linaro.org>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-imx-tpm.c

index fcdf6be..aaf629b 100644 (file)
@@ -350,13 +350,9 @@ static int pwm_imx_tpm_probe(struct platform_device *pdev)
                return PTR_ERR(tpm->base);
 
        tpm->clk = devm_clk_get(&pdev->dev, NULL);
-       if (IS_ERR(tpm->clk)) {
-               ret = PTR_ERR(tpm->clk);
-               if (ret != -EPROBE_DEFER)
-                       dev_err(&pdev->dev,
-                               "failed to get PWM clock: %d\n", ret);
-               return ret;
-       }
+       if (IS_ERR(tpm->clk))
+               return dev_err_probe(&pdev->dev, PTR_ERR(tpm->clk),
+                                    "failed to get PWM clock\n");
 
        ret = clk_prepare_enable(tpm->clk);
        if (ret) {