arm64: dts: intel: socfpga: override clocks by label
authorKrzysztof Kozlowski <krzk@kernel.org>
Mon, 8 Mar 2021 17:09:37 +0000 (18:09 +0100)
committerDinh Nguyen <dinguyen@kernel.org>
Tue, 30 Mar 2021 10:51:29 +0000 (05:51 -0500)
Using full paths to extend or override a device tree node is error
prone.  If there was a typo error, a new node will be created instead of
extending the existing node.  This will lead to run-time errors that
could be hard to detect.

A mistyped label on the other hand, will cause a dtc compile error
(during build time).

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
arch/arm64/boot/dts/intel/socfpga_agilex_socdk_nand.dts
arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts

index a7a83f2..f14a89c 100644 (file)
                /* We expect the bootloader to fill in the reg */
                reg = <0 0 0 0>;
        };
-
-       soc {
-               clocks {
-                       osc1 {
-                               clock-frequency = <25000000>;
-                       };
-               };
-       };
 };
 
 &gpio1 {
        bus-width = <4>;
 };
 
+&osc1 {
+       clock-frequency = <25000000>;
+};
+
 &uart0 {
        status = "okay";
 };
index 979aa59..58a827a 100644 (file)
                /* We expect the bootloader to fill in the reg */
                reg = <0 0 0 0>;
        };
-
-       soc {
-               clocks {
-                       osc1 {
-                               clock-frequency = <25000000>;
-                       };
-               };
-       };
 };
 
 &gpio1 {
        };
 };
 
+&osc1 {
+       clock-frequency = <25000000>;
+};
+
 &uart0 {
        status = "okay";
 };
index 5f56e26..01f1307 100644 (file)
                /* We expect the bootloader to fill in the reg */
                reg = <0 0 0 0>;
        };
-
-       soc {
-               clocks {
-                       osc1 {
-                               clock-frequency = <25000000>;
-                       };
-               };
-       };
 };
 
 &clkmgr {
        bus-width = <4>;
 };
 
+&osc1 {
+       clock-frequency = <25000000>;
+};
+
 &uart0 {
        status = "okay";
 };