PCI: dwc: Use of_property_present() for non-boolean properties
authorRob Herring (Arm) <robh@kernel.org>
Mon, 4 Nov 2024 19:07:13 +0000 (13:07 -0600)
committerKrzysztof Wilczyński <kwilczynski@kernel.org>
Sat, 16 Nov 2024 18:21:06 +0000 (18:21 +0000)
The use of of_property_read_bool() for non-boolean properties is
deprecated in favor of of_property_present() when testing for property
presence.

Link: https://lore.kernel.org/r/20241104190714.275977-1-robh@kernel.org
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
drivers/pci/controller/dwc/pcie-designware-host.c

index 3e41865..d2291c3 100644 (file)
@@ -474,8 +474,8 @@ int dw_pcie_host_init(struct dw_pcie_rp *pp)
 
        if (pci_msi_enabled()) {
                pp->has_msi_ctrl = !(pp->ops->msi_init ||
-                                    of_property_read_bool(np, "msi-parent") ||
-                                    of_property_read_bool(np, "msi-map"));
+                                    of_property_present(np, "msi-parent") ||
+                                    of_property_present(np, "msi-map"));
 
                /*
                 * For the has_msi_ctrl case the default assignment is handled