drm/bridge: nwl-dsi: Remove superfluous write to NWL_DSI_IRQ_MASK register
authorLiu Ying <victor.liu@nxp.com>
Wed, 16 Feb 2022 08:58:42 +0000 (16:58 +0800)
committerRobert Foss <robert.foss@linaro.org>
Wed, 2 Mar 2022 13:11:39 +0000 (14:11 +0100)
To initialize register NWL_DSI_IRQ_MASK, it's enough to write it
only once in function nwl_dsi_init_interrupts().

Signed-off-by: Liu Ying <victor.liu@nxp.com>
Reviewed-by: Guido Günther <agx@sigxcpu.org>
Signed-off-by: Robert Foss <robert.foss@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20220216085842.1973868-1-victor.liu@nxp.com
drivers/gpu/drm/bridge/nwl-dsi.c

index 30aacd9..71b24e2 100644 (file)
@@ -334,17 +334,13 @@ static int nwl_dsi_config_dpi(struct nwl_dsi *dsi)
 
 static int nwl_dsi_init_interrupts(struct nwl_dsi *dsi)
 {
-       u32 irq_enable;
-
-       nwl_dsi_write(dsi, NWL_DSI_IRQ_MASK, 0xffffffff);
-       nwl_dsi_write(dsi, NWL_DSI_IRQ_MASK2, 0x7);
-
-       irq_enable = ~(u32)(NWL_DSI_TX_PKT_DONE_MASK |
-                           NWL_DSI_RX_PKT_HDR_RCVD_MASK |
-                           NWL_DSI_TX_FIFO_OVFLW_MASK |
-                           NWL_DSI_HS_TX_TIMEOUT_MASK);
+       u32 irq_enable = ~(u32)(NWL_DSI_TX_PKT_DONE_MASK |
+                               NWL_DSI_RX_PKT_HDR_RCVD_MASK |
+                               NWL_DSI_TX_FIFO_OVFLW_MASK |
+                               NWL_DSI_HS_TX_TIMEOUT_MASK);
 
        nwl_dsi_write(dsi, NWL_DSI_IRQ_MASK, irq_enable);
+       nwl_dsi_write(dsi, NWL_DSI_IRQ_MASK2, 0x7);
 
        return nwl_dsi_clear_error(dsi);
 }