firewire: core: remove useless lockdep_assert_held()
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>
Thu, 11 Sep 2025 22:13:11 +0000 (07:13 +0900)
committerTakashi Sakamoto <o-takashi@sakamocchi.jp>
Thu, 11 Sep 2025 22:54:23 +0000 (07:54 +0900)
The bm_work work item should be scheduled after holding fw_card reference
counting. At a commit 25feb1a96e21 ("firewire: core: use cleanup function
in bm_work"), I misinterpreted it as fw_card spinlock and inserted
lockdep_assert_hold() wrongly.

This commit removes the useless line.

Fixes: 25feb1a96e21 ("firewire: core: use cleanup function in bm_work")
Link: https://lore.kernel.org/r/20250911221312.678076-1-o-takashi@sakamocchi.jp
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
drivers/firewire/core-card.c

index 474d806..32cf6b3 100644 (file)
@@ -294,8 +294,6 @@ static void bm_work(struct work_struct *work)
        int expected_gap_count, generation, grace;
        bool do_reset = false;
 
-       lockdep_assert_held(&card->lock);
-
        spin_lock_irq(&card->lock);
 
        if (card->local_node == NULL) {