scsi: libiscsi: Annotate locking assumptions
authorBart Van Assche <bart.vanassche@wdc.com>
Mon, 30 Jul 2018 21:40:18 +0000 (14:40 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 31 Jul 2018 03:17:53 +0000 (23:17 -0400)
This patch avoids that sparse reports the following:

drivers/scsi/libiscsi.c:1844:23: warning: context imbalance in 'iscsi_exec_task_mgmt_fn' - unexpected unlock

Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Signed-off-by: Lee Duncan <lduncan@suse.com>
Signed-off-by: Chris Leech <cleech@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/libiscsi.c

index d609383..b36bafd 100644 (file)
@@ -1832,6 +1832,7 @@ static void iscsi_tmf_timedout(struct timer_list *t)
 static int iscsi_exec_task_mgmt_fn(struct iscsi_conn *conn,
                                   struct iscsi_tm *hdr, int age,
                                   int timeout)
+       __must_hold(&session->frwd_lock)
 {
        struct iscsi_session *session = conn->session;
        struct iscsi_task *task;