spi: tegra210-quad: Put device into suspend on driver removal
authorDmitry Osipenko <digetx@gmail.com>
Sat, 23 Oct 2021 22:59:51 +0000 (01:59 +0300)
committerMark Brown <broonie@kernel.org>
Tue, 26 Oct 2021 19:03:59 +0000 (20:03 +0100)
pm_runtime_disable() cancels all pending power requests, while they
should be completed for the Tegra SPI driver. Otherwise SPI clock won't
be disabled ever again because clk refcount will become unbalanced.
Enforce runtime PM suspension to put device into expected state before
driver is unbound and device's RPM state is reset by driver's core.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Link: https://lore.kernel.org/r/20211023225951.14253-2-digetx@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-tegra210-quad.c

index 2354ca1..c0f9a75 100644 (file)
@@ -1318,7 +1318,7 @@ static int tegra_qspi_probe(struct platform_device *pdev)
 exit_free_irq:
        free_irq(qspi_irq, tqspi);
 exit_pm_disable:
-       pm_runtime_disable(&pdev->dev);
+       pm_runtime_force_suspend(&pdev->dev);
        tegra_qspi_deinit_dma(tqspi);
        return ret;
 }
@@ -1330,7 +1330,7 @@ static int tegra_qspi_remove(struct platform_device *pdev)
 
        spi_unregister_master(master);
        free_irq(tqspi->irq, tqspi);
-       pm_runtime_disable(&pdev->dev);
+       pm_runtime_force_suspend(&pdev->dev);
        tegra_qspi_deinit_dma(tqspi);
 
        return 0;