crypto: ccp - Release all allocated memory if sha type is invalid
authorNavid Emamdoost <navid.emamdoost@gmail.com>
Thu, 19 Sep 2019 16:04:48 +0000 (11:04 -0500)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 4 Oct 2019 15:06:20 +0000 (01:06 +1000)
Release all allocated memory if sha type is invalid:
In ccp_run_sha_cmd, if the type of sha is invalid, the allocated
hmac_buf should be released.

v2: fix the goto.

Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Acked-by: Gary R Hook <gary.hook@amd.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/ccp/ccp-ops.c

index c8da8eb..4221936 100644 (file)
@@ -1777,8 +1777,9 @@ ccp_run_sha_cmd(struct ccp_cmd_queue *cmd_q, struct ccp_cmd *cmd)
                               LSB_ITEM_SIZE);
                        break;
                default:
+                       kfree(hmac_buf);
                        ret = -EINVAL;
-                       goto e_ctx;
+                       goto e_data;
                }
 
                memset(&hmac_cmd, 0, sizeof(hmac_cmd));