virtio-net: don't allocate control_buf if not supported
authorMax Gurtovoy <mgurtovoy@nvidia.com>
Sun, 2 May 2021 09:33:19 +0000 (12:33 +0300)
committerMichael S. Tsirkin <mst@redhat.com>
Mon, 3 May 2021 08:55:51 +0000 (04:55 -0400)
Not all virtio_net devices support the ctrl queue feature. Thus, there
is no need to allocate unused resources.

Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
Link: https://lore.kernel.org/r/20210502093319.61313-1-mgurtovoy@nvidia.com
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
drivers/net/virtio_net.c

index 0824e69..ac0c143 100644 (file)
@@ -2801,9 +2801,13 @@ static int virtnet_alloc_queues(struct virtnet_info *vi)
 {
        int i;
 
-       vi->ctrl = kzalloc(sizeof(*vi->ctrl), GFP_KERNEL);
-       if (!vi->ctrl)
-               goto err_ctrl;
+       if (vi->has_cvq) {
+               vi->ctrl = kzalloc(sizeof(*vi->ctrl), GFP_KERNEL);
+               if (!vi->ctrl)
+                       goto err_ctrl;
+       } else {
+               vi->ctrl = NULL;
+       }
        vi->sq = kcalloc(vi->max_queue_pairs, sizeof(*vi->sq), GFP_KERNEL);
        if (!vi->sq)
                goto err_sq;