ALSA: PCM: Allow resume only for suspended streams

snd_pcm_resume() should bail out if the stream isn't in a suspended
state.  Otherwise it'd allow doubly resume.

Link: https://patch.msgid.link/20240624125443.27808-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>

diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
index 521ba56..c152ccf 100644 (file)
--- a/sound/core/pcm_native.c
+++ b/sound/core/pcm_native.c
@@ -1775,6 +1775,8 @@ static int snd_pcm_pre_resume(struct snd_pcm_substream *substream,
                              snd_pcm_state_t state)
 {
        struct snd_pcm_runtime *runtime = substream->runtime;
+       if (runtime->state != SNDRV_PCM_STATE_SUSPENDED)
+               return -EBADFD;
        if (!(runtime->info & SNDRV_PCM_INFO_RESUME))
                return -ENOSYS;
        runtime->trigger_master = substream;