media: rkvdec: Remove redundant platform_get_irq error message
authorYueHaibing <yuehaibing@huawei.com>
Wed, 9 Sep 2020 14:24:07 +0000 (16:24 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 16 Nov 2020 09:31:08 +0000 (10:31 +0100)
platform_get_irq() will call dev_err() itself on failure,
so there is no need for the driver to also do this.
This is detected by coccinelle.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/rkvdec/rkvdec.c

index d25c4a3..552e0bd 100644 (file)
@@ -1038,10 +1038,8 @@ static int rkvdec_probe(struct platform_device *pdev)
        vb2_dma_contig_set_max_seg_size(&pdev->dev, DMA_BIT_MASK(32));
 
        irq = platform_get_irq(pdev, 0);
-       if (irq <= 0) {
-               dev_err(&pdev->dev, "Could not get vdec IRQ\n");
+       if (irq <= 0)
                return -ENXIO;
-       }
 
        ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
                                        rkvdec_irq_handler, IRQF_ONESHOT,