vmxnet3: allow rx flow hash ops only when rss is enabled
authorRonak Doshi <doshir@vmware.com>
Tue, 2 Jun 2020 03:02:39 +0000 (20:02 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 2 Jun 2020 22:12:33 +0000 (15:12 -0700)
It makes sense to allow changes to get/set rx flow hash callback only
when rss is enabled. This patch restricts get_rss_hash_opts and
set_rss_hash_opts methods to allow querying and configuring different
Rx flow hash configurations only when rss is enabled

Signed-off-by: Ronak Doshi <doshir@vmware.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/vmxnet3/vmxnet3_ethtool.c

index 6acaafe..def27af 100644 (file)
@@ -899,6 +899,12 @@ vmxnet3_get_rxnfc(struct net_device *netdev, struct ethtool_rxnfc *info,
                        err = -EOPNOTSUPP;
                        break;
                }
+#ifdef VMXNET3_RSS
+               if (!adapter->rss) {
+                       err = -EOPNOTSUPP;
+                       break;
+               }
+#endif
                err = vmxnet3_get_rss_hash_opts(adapter, info);
                break;
        default:
@@ -919,6 +925,12 @@ vmxnet3_set_rxnfc(struct net_device *netdev, struct ethtool_rxnfc *info)
                err = -EOPNOTSUPP;
                goto done;
        }
+#ifdef VMXNET3_RSS
+       if (!adapter->rss) {
+               err = -EOPNOTSUPP;
+               goto done;
+       }
+#endif
 
        switch (info->cmd) {
        case ETHTOOL_SRXFH: