projects
/
linux-2.6-microblaze.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
b3d6637
)
powerpc/powermac/pfunc_base: Add missing of_node_put() in macio_gpio_init_one()
author
Liang He
<windhl@126.com>
Sat, 16 Jul 2022 07:31:11 +0000
(15:31 +0800)
committer
Michael Ellerman
<mpe@ellerman.id.au>
Mon, 5 Sep 2022 07:30:29 +0000
(17:30 +1000)
Call of_node_put() for the reference 'gparent' escaped out of the
previous for_each_child_of_node() as it has increased the refcount.
Signed-off-by: Liang He <windhl@126.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link:
https://lore.kernel.org/r/20220716073111.539739-1-windhl@126.com
arch/powerpc/platforms/powermac/pfunc_base.c
patch
|
blob
|
history
diff --git
a/arch/powerpc/platforms/powermac/pfunc_base.c
b/arch/powerpc/platforms/powermac/pfunc_base.c
index
9c2947a
..
085e0ad
100644
(file)
--- a/
arch/powerpc/platforms/powermac/pfunc_base.c
+++ b/
arch/powerpc/platforms/powermac/pfunc_base.c
@@
-136,6
+136,8
@@
static void __init macio_gpio_init_one(struct macio_chip *macio)
for_each_child_of_node(gparent, gp)
pmf_do_functions(gp, NULL, 0, PMF_FLAGS_ON_INIT, NULL);
+ of_node_put(gparent);
+
/* Note: We do not at this point implement the "at sleep" or "at wake"
* functions. I yet to find any for GPIOs anyway
*/