tracing/kprobe: Fix uninitialized variable bug
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Wed, 5 Feb 2020 22:34:04 +0000 (16:34 -0600)
committerSteven Rostedt (VMware) <rostedt@goodmis.org>
Mon, 10 Feb 2020 17:07:42 +0000 (12:07 -0500)
There is a potential execution path in which variable *ret* is returned
without being properly initialized, previously.

Fix this by initializing variable *ret* to 0.

Link: http://lkml.kernel.org/r/20200205223404.GA3379@embeddedor
Addresses-Coverity-ID: 1491142 ("Uninitialized scalar variable")
Fixes: 2a588dd1d5d6 ("tracing: Add kprobe event command generation functions")
Reviewed-by: Tom Zanussi <zanussi@kernel.org>
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
kernel/trace/trace_kprobe.c

index 51efc79..21bafd4 100644 (file)
@@ -1012,7 +1012,7 @@ int __kprobe_event_add_fields(struct dynevent_cmd *cmd, ...)
 {
        struct dynevent_arg arg;
        va_list args;
-       int ret;
+       int ret = 0;
 
        if (cmd->type != DYNEVENT_TYPE_KPROBE)
                return -EINVAL;