media: hantro: use pm_runtime_resume_and_get()
authorMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 26 Apr 2021 12:26:43 +0000 (14:26 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 20 May 2021 14:02:44 +0000 (16:02 +0200)
Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter")
added pm_runtime_resume_and_get() in order to automatically handle
dev->power.usage_count decrement on errors.

While there's nothing wrong with the current usage on this driver,
as we're getting rid of the pm_runtime_get_sync() call all over
the media subsystem, let's remove the last occurrence on this
driver.

Reviewed-by: Ezequiel Garcia <ezequiel@collabora.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/hantro/hantro_drv.c

index 85dcb08..074b9bb 100644 (file)
@@ -160,11 +160,9 @@ static void device_run(void *priv)
        src = hantro_get_src_buf(ctx);
        dst = hantro_get_dst_buf(ctx);
 
-       ret = pm_runtime_get_sync(ctx->dev->dev);
-       if (ret < 0) {
-               pm_runtime_put_noidle(ctx->dev->dev);
+       ret = pm_runtime_resume_and_get(ctx->dev->dev);
+       if (ret < 0)
                goto err_cancel_job;
-       }
 
        ret = clk_bulk_enable(ctx->dev->variant->num_clocks, ctx->dev->clocks);
        if (ret)