i3c: dw: Disable IBI IRQ depends on hot-join and SIR enabling
authorDylan Hung <dylan_hung@aspeedtech.com>
Fri, 19 Jan 2024 05:45:47 +0000 (13:45 +0800)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Sun, 18 Feb 2024 23:32:34 +0000 (00:32 +0100)
Disable IBI IRQ signal and status only when hot-join and SIR enabling of
all target devices attached to the bus are disabled.

Fixes: e389b1d72a62 ("i3c: dw: Add support for in-band interrupts")

Signed-off-by: Dylan Hung <dylan_hung@aspeedtech.com>
Link: https://lore.kernel.org/r/20240119054547.983693-1-dylan_hung@aspeedtech.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/i3c/master/dw-i3c-master.c

index ef5751e..276153e 100644 (file)
@@ -1163,8 +1163,10 @@ static void dw_i3c_master_set_sir_enabled(struct dw_i3c_master *master,
                global = reg == 0xffffffff;
                reg &= ~BIT(idx);
        } else {
-               global = reg == 0;
+               bool hj_rejected = !!(readl(master->regs + DEVICE_CTRL) & DEV_CTRL_HOT_JOIN_NACK);
+
                reg |= BIT(idx);
+               global = (reg == 0xffffffff) && hj_rejected;
        }
        writel(reg, master->regs + IBI_SIR_REQ_REJECT);