driver core: Remove the link if there is no driver with AUTO flag
authorYong Wu <yong.wu@mediatek.com>
Tue, 1 Jan 2019 04:51:05 +0000 (12:51 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 22 Jan 2019 13:25:26 +0000 (14:25 +0100)
DL_FLAG_AUTOREMOVE_CONSUMER/SUPPLIER means "Remove the link
automatically on consumer/supplier driver unbind", that means we should
remove whole the device_link when there is no this driver no matter what
the ref_count of the link is.

CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Yong Wu <yong.wu@mediatek.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/core.c

index 4e57e16..26f8cd6 100644 (file)
@@ -512,7 +512,7 @@ static void __device_links_no_driver(struct device *dev)
                        continue;
 
                if (link->flags & DL_FLAG_AUTOREMOVE_CONSUMER)
-                       kref_put(&link->kref, __device_link_del);
+                       __device_link_del(&link->kref);
                else if (link->status != DL_STATE_SUPPLIER_UNBIND)
                        WRITE_ONCE(link->status, DL_STATE_AVAILABLE);
        }
@@ -557,7 +557,7 @@ void device_links_driver_cleanup(struct device *dev)
                 */
                if (link->status == DL_STATE_SUPPLIER_UNBIND &&
                    link->flags & DL_FLAG_AUTOREMOVE_SUPPLIER)
-                       kref_put(&link->kref, __device_link_del);
+                       __device_link_del(&link->kref);
 
                WRITE_ONCE(link->status, DL_STATE_DORMANT);
        }