atm: switch do_atmif_sioc() to direct use of atm_dev_ioctl()
authorAl Viro <viro@zeniv.linux.org.uk>
Sun, 10 May 2020 22:13:56 +0000 (18:13 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Thu, 21 May 2020 00:31:36 +0000 (20:31 -0400)
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
net/atm/ioctl.c

index 52f2c77..838ebf0 100644 (file)
@@ -286,30 +286,13 @@ static int do_atm_iobuf(struct socket *sock, unsigned int cmd,
 static int do_atmif_sioc(struct socket *sock, unsigned int cmd,
                         unsigned long arg)
 {
-       struct atmif_sioc __user *sioc;
-       struct compat_atmif_sioc __user *sioc32;
+       struct compat_atmif_sioc __user *sioc32 = compat_ptr(arg);
+       int number;
        u32 data;
-       void __user *datap;
-       int err;
 
-       sioc = compat_alloc_user_space(sizeof(*sioc));
-       sioc32 = compat_ptr(arg);
-
-       if (copy_in_user(&sioc->number, &sioc32->number, 2 * sizeof(int)) ||
-           get_user(data, &sioc32->arg))
-               return -EFAULT;
-       datap = compat_ptr(data);
-       if (put_user(datap, &sioc->arg))
+       if (get_user(data, &sioc32->arg) || get_user(number, &sioc32->number))
                return -EFAULT;
-
-       err = do_vcc_ioctl(sock, cmd, (unsigned long) sioc, 0);
-
-       if (!err) {
-               if (copy_in_user(&sioc32->length, &sioc->length,
-                                sizeof(int)))
-                       err = -EFAULT;
-       }
-       return err;
+       return atm_dev_ioctl(cmd, compat_ptr(data), &sioc32->length, number, 0);
 }
 
 static int do_atm_ioctl(struct socket *sock, unsigned int cmd32,