serial: mvebu-uart: drop incorrect memset
authorArnd Bergmann <arnd@arndb.de>
Thu, 2 Nov 2017 11:34:24 +0000 (12:34 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 4 Nov 2017 11:08:53 +0000 (12:08 +0100)
gcc points out that the length passed into memset here is wrong:

drivers/tty/serial/mvebu-uart.c: In function 'mvebu_uart_probe':
arch/x86/include/asm/string_32.h:324:29: error: 'memset' used with length equal to number of elements without multiplication by element size [-Werror=memset-elt-size]

Moreover, the structure was allocated with kzalloc a few lines earlier,
so that memset is also unnecessary. Let's drop it to shut up the
compiler warning.

Fixes: 95f787685a22 ("serial: mvebu-uart: dissociate RX and TX interrupts")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/mvebu-uart.c

index 16b0a5a..85eb5c8 100644 (file)
@@ -817,7 +817,6 @@ static int mvebu_uart_probe(struct platform_device *pdev)
        }
 
        /* Manage interrupts */
-       memset(mvuart->irq, 0, UART_IRQ_COUNT);
        if (platform_irq_count(pdev) == 1) {
                /* Old bindings: no name on the single unamed UART0 IRQ */
                irq = platform_get_irq(pdev, 0);