net: ethernet: broadcom: Remove null check before kfree
authorHimanshu Jha <himanshujha199640@gmail.com>
Sat, 26 Aug 2017 20:17:47 +0000 (01:47 +0530)
committerDavid S. Miller <davem@davemloft.net>
Mon, 28 Aug 2017 22:53:23 +0000 (15:53 -0700)
Kfree on NULL pointer is a no-op and therefore checking is redundant.

Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/sb1250-mac.c

index 16a0f19..ecdef42 100644 (file)
@@ -1367,15 +1367,11 @@ static int sbmac_initctx(struct sbmac_softc *s)
 
 static void sbdma_uninitctx(struct sbmacdma *d)
 {
-       if (d->sbdma_dscrtable_unaligned) {
-               kfree(d->sbdma_dscrtable_unaligned);
-               d->sbdma_dscrtable_unaligned = d->sbdma_dscrtable = NULL;
-       }
+       kfree(d->sbdma_dscrtable_unaligned);
+       d->sbdma_dscrtable_unaligned = d->sbdma_dscrtable = NULL;
 
-       if (d->sbdma_ctxtable) {
-               kfree(d->sbdma_ctxtable);
-               d->sbdma_ctxtable = NULL;
-       }
+       kfree(d->sbdma_ctxtable);
+       d->sbdma_ctxtable = NULL;
 }