ASoC: amd: fix for variable set but not used warning
authorVijendar Mukunda <Vijendar.Mukunda@amd.com>
Thu, 7 Jul 2022 13:26:10 +0000 (18:56 +0530)
committerMark Brown <broonie@kernel.org>
Fri, 8 Jul 2022 10:51:50 +0000 (11:51 +0100)
Fix below kernel warning.
>>> sound/soc/amd/acp-es8336.c:200:13: warning: variable 'ret' set but
>>> not used [-Wunused-but-set-variable]

Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/r/20220707132613.3150931-3-Vijendar.Mukunda@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/amd/acp-es8336.c

index a999762..ebd4fa9 100644 (file)
@@ -206,6 +206,8 @@ static int st_es8336_late_probe(struct snd_soc_card *card)
                dev_err(card->dev, "can not find codec dev\n");
 
        ret = devm_acpi_dev_add_driver_gpios(codec_dev, acpi_es8336_gpios);
+       if (ret)
+               dev_warn(card->dev, "Failed to add driver gpios\n");
 
        gpio_pa = gpiod_get_optional(codec_dev, "pa-enable", GPIOD_OUT_LOW);
        if (IS_ERR(gpio_pa)) {
@@ -213,6 +215,7 @@ static int st_es8336_late_probe(struct snd_soc_card *card)
                                    "could not get pa-enable GPIO\n");
                gpiod_put(gpio_pa);
                put_device(codec_dev);
+               return ret;
        }
        return 0;
 }