drm/i915: Convert MBUS_ABOX_CTL() to _PICK_EVEN_2RANGES()
authorLucas De Marchi <lucas.demarchi@intel.com>
Fri, 20 Jan 2023 19:34:56 +0000 (11:34 -0800)
committerLucas De Marchi <lucas.demarchi@intel.com>
Fri, 27 Jan 2023 16:53:00 +0000 (08:53 -0800)
MBUS_ABOX_CTL() can use _PICK_EVEN_2RANGES instead of _PICK, which
reduces the size and is safer.

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230120193457.3295977-8-lucas.demarchi@intel.com
drivers/gpu/drm/i915/i915_reg.h

index d63d735..539e4b1 100644 (file)
 #define _MBUS_ABOX0_CTL                        0x45038
 #define _MBUS_ABOX1_CTL                        0x45048
 #define _MBUS_ABOX2_CTL                        0x4504C
-#define MBUS_ABOX_CTL(x)               _MMIO(_PICK(x, _MBUS_ABOX0_CTL, \
-                                                   _MBUS_ABOX1_CTL, \
-                                                   _MBUS_ABOX2_CTL))
+#define MBUS_ABOX_CTL(x)                                                       \
+       _MMIO(_PICK_EVEN_2RANGES(x, 2,                                          \
+                                _MBUS_ABOX0_CTL, _MBUS_ABOX1_CTL,              \
+                                _MBUS_ABOX2_CTL, _MBUS_ABOX2_CTL))
+
 #define MBUS_ABOX_BW_CREDIT_MASK       (3 << 20)
 #define MBUS_ABOX_BW_CREDIT(x)         ((x) << 20)
 #define MBUS_ABOX_B_CREDIT_MASK                (0xF << 16)