drm/omap: dsi: Add missing IRQF_ONESHOT
authorYang Li <yang.lee@linux.alibaba.com>
Tue, 23 Mar 2021 09:34:53 +0000 (17:34 +0800)
committerTomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Fri, 26 Mar 2021 07:23:13 +0000 (09:23 +0200)
fixed the following coccicheck:
./drivers/gpu/drm/omapdrm/dss/dsi.c:4329:7-27: ERROR: Threaded IRQ with
no primary handler requested without IRQF_ONESHOT

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Fixes: 4c1b935fea54 ("drm/omap: dsi: move TE GPIO handling into core")
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Link: https://patchwork.freedesktop.org/patch/msgid/1616492093-68237-1-git-send-email-yang.lee@linux.alibaba.com
drivers/gpu/drm/omapdrm/dss/dsi.c

index febcc87..022a8d5 100644 (file)
@@ -4327,7 +4327,8 @@ static int omap_dsi_register_te_irq(struct dsi_data *dsi,
        irq_set_status_flags(te_irq, IRQ_NOAUTOEN);
 
        err = request_threaded_irq(te_irq, NULL, omap_dsi_te_irq_handler,
-                                  IRQF_TRIGGER_RISING, "TE", dsi);
+                                  IRQF_TRIGGER_RISING | IRQF_ONESHOT,
+                                  "TE", dsi);
        if (err) {
                dev_err(dsi->dev, "request irq failed with %d\n", err);
                gpiod_put(dsi->te_gpio);