mlxsw: spectrum_router: Pass destination IP as a pointer to mlxsw_reg_ralue_pack4()

Instead of passing destination IP as a u32 value, pass it as pointer to
u32. Avoid using local variable for the pointer store.

Signed-off-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/ethernet/mellanox/mlxsw/reg.h b/drivers/net/ethernet/mellanox/mlxsw/reg.h
index 73aab72..0da9f7e 100644 (file)
--- a/drivers/net/ethernet/mellanox/mlxsw/reg.h
+++ b/drivers/net/ethernet/mellanox/mlxsw/reg.h
@@ -7279,10 +7279,10 @@ static inline void mlxsw_reg_ralue_pack4(char *payload,
                                         enum mlxsw_reg_ralxx_protocol protocol,
                                         enum mlxsw_reg_ralue_op op,
                                         u16 virtual_router, u8 prefix_len,
-                                        u32 dip)
+                                        u32 *dip)
 {
        mlxsw_reg_ralue_pack(payload, protocol, op, virtual_router, prefix_len);
-       mlxsw_reg_ralue_dip4_set(payload, dip);
+       mlxsw_reg_ralue_dip4_set(payload, *dip);
 }
 
 static inline void mlxsw_reg_ralue_pack6(char *payload,

diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
index 3ed9bd4..4edb2ee 100644 (file)
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
@@ -4314,7 +4314,6 @@ mlxsw_sp_fib_entry_ralue_pack(char *ralue_pl, enum mlxsw_sp_l3proto proto,
 {
        enum mlxsw_reg_ralxx_protocol ralxx_proto;
        enum mlxsw_reg_ralue_op ralue_op;
-       u32 *p_dip;
 
        ralxx_proto = (enum mlxsw_reg_ralxx_protocol) proto;
 
@@ -4332,9 +4331,8 @@ mlxsw_sp_fib_entry_ralue_pack(char *ralue_pl, enum mlxsw_sp_l3proto proto,
 
        switch (proto) {
        case MLXSW_SP_L3_PROTO_IPV4:
-               p_dip = (u32 *) addr;
                mlxsw_reg_ralue_pack4(ralue_pl, ralxx_proto, ralue_op,
-                                     virtual_router, prefix_len, *p_dip);
+                                     virtual_router, prefix_len, (u32 *) addr);
                break;
        case MLXSW_SP_L3_PROTO_IPV6:
                mlxsw_reg_ralue_pack6(ralue_pl, ralxx_proto, ralue_op,