staging: r8188eu: use is_multicast_ether_addr in hal/rtl8188eu_xmit.c
authorMichael Straube <straube.linux@gmail.com>
Mon, 23 Aug 2021 12:01:05 +0000 (14:01 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 26 Aug 2021 10:23:13 +0000 (12:23 +0200)
Use is_multicast_ether_addr instead of custom macro IS_MCAST, the
buffer is properly aligned.

Acked-by: Phillip Potter <phil@philpotter.co.uk>
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20210823120106.9633-8-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/hal/rtl8188eu_xmit.c

index d22b16c..17be67a 100644 (file)
@@ -167,7 +167,6 @@ static s32 update_txdesc(struct xmit_frame *pxmitframe, u8 *pmem, s32 sz, u8 bag
        struct tx_desc  *ptxdesc = (struct tx_desc *)pmem;
        struct mlme_ext_priv    *pmlmeext = &adapt->mlmeextpriv;
        struct mlme_ext_info    *pmlmeinfo = &pmlmeext->mlmext_info;
-       int     bmcst = IS_MCAST(pattrib->ra);
 
        if (adapt->registrypriv.mp_mode == 0) {
                if ((!bagg_pkt) && (urb_zero_packet_chk(adapt, sz) == 0)) {
@@ -186,7 +185,7 @@ static s32 update_txdesc(struct xmit_frame *pxmitframe, u8 *pmem, s32 sz, u8 bag
 
        ptxdesc->txdw0 |= cpu_to_le32(((offset) << OFFSET_SHT) & 0x00ff0000);/* 32 bytes for TX Desc */
 
-       if (bmcst)
+       if (is_multicast_ether_addr(pattrib->ra))
                ptxdesc->txdw0 |= cpu_to_le32(BMC);
 
        if (adapt->registrypriv.mp_mode == 0) {