phy: phy-omap-usb2: Remove unncessary site specific OOM messages
authorPeter Griffin <peter.griffin@linaro.org>
Fri, 15 Aug 2014 12:40:10 +0000 (13:40 +0100)
committerKishon Vijay Abraham I <kishon@ti.com>
Wed, 24 Sep 2014 09:48:32 +0000 (15:18 +0530)
The site specific OOM messages are unncessary, because they duplicate
messages from the memory subsystem which include dump_stack().

Removing these superflous messages makes the kernel smaller. A discussion
here http://patchwork.ozlabs.org/patch/324158/ found that all error paths
from kzalloc will print a error message, and that any error path which maybe
found which doesn't would be considered a bug in kzalloc.

Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
drivers/phy/phy-omap-usb2.c

index 93d7835..51c6f92 100644 (file)
@@ -212,16 +212,12 @@ static int omap_usb2_probe(struct platform_device *pdev)
        phy_data = (struct usb_phy_data *)of_id->data;
 
        phy = devm_kzalloc(&pdev->dev, sizeof(*phy), GFP_KERNEL);
-       if (!phy) {
-               dev_err(&pdev->dev, "unable to allocate memory for USB2 PHY\n");
+       if (!phy)
                return -ENOMEM;
-       }
 
        otg = devm_kzalloc(&pdev->dev, sizeof(*otg), GFP_KERNEL);
-       if (!otg) {
-               dev_err(&pdev->dev, "unable to allocate memory for USB OTG\n");
+       if (!otg)
                return -ENOMEM;
-       }
 
        phy->dev                = &pdev->dev;