Input: gpio-keys - filter gpio_keys -EPROBE_DEFER error messages
authorHermes Zhang <chenhuiz@axis.com>
Fri, 29 Dec 2023 01:36:57 +0000 (09:36 +0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Fri, 29 Dec 2023 07:44:55 +0000 (23:44 -0800)
commit ae42f9288846 ("gpio: Return EPROBE_DEFER if gc->to_irq is NULL")
make gpiod_to_irq() possible to return -EPROBE_DEFER when the racing
happens. This causes the following error message to be printed:

    gpio-keys gpio_keys: Unable to get irq number for GPIO 0, error -517

Fix that by changing dev_err() to dev_err_probe()

Signed-off-by: Hermes Zhang <chenhuiz@axis.com>
Link: https://lore.kernel.org/r/20231229013657.692600-1-Hermes.Zhang@axis.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/keyboard/gpio_keys.c

index 06c09b7..9f3bcd4 100644 (file)
@@ -592,9 +592,9 @@ static int gpio_keys_setup_key(struct platform_device *pdev,
                        irq = gpiod_to_irq(bdata->gpiod);
                        if (irq < 0) {
                                error = irq;
-                               dev_err(dev,
-                                       "Unable to get irq number for GPIO %d, error %d\n",
-                                       button->gpio, error);
+                               dev_err_probe(dev, error,
+                                             "Unable to get irq number for GPIO %d\n",
+                                             button->gpio);
                                return error;
                        }
                        bdata->irq = irq;