drm/i915/sseu: Move sseu_info under gt_info
authorVenkata Sandeep Dhanalakota <venkata.s.dhanalakota@intel.com>
Wed, 8 Jul 2020 00:39:50 +0000 (17:39 -0700)
committerChris Wilson <chris@chris-wilson.co.uk>
Wed, 8 Jul 2020 20:13:09 +0000 (21:13 +0100)
SSEUs are a GT capability, so track them under gt_info.

Signed-off-by: Venkata Sandeep Dhanalakota <venkata.s.dhanalakota@intel.com>
Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Andi Shyti <andi.shyti@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20200708003952.21831-8-daniele.ceraolospurio@intel.com
20 files changed:
drivers/gpu/drm/i915/gem/i915_gem_context.c
drivers/gpu/drm/i915/gem/i915_gem_context.h
drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
drivers/gpu/drm/i915/gt/intel_context_sseu.c
drivers/gpu/drm/i915/gt/intel_engine_cs.c
drivers/gpu/drm/i915/gt/intel_gt.c
drivers/gpu/drm/i915/gt/intel_gt_types.h
drivers/gpu/drm/i915/gt/intel_lrc.c
drivers/gpu/drm/i915/gt/intel_rps.c
drivers/gpu/drm/i915/gt/intel_sseu.c
drivers/gpu/drm/i915/gt/intel_sseu.h
drivers/gpu/drm/i915/gt/intel_workarounds.c
drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c
drivers/gpu/drm/i915/i915_debugfs.c
drivers/gpu/drm/i915/i915_getparam.c
drivers/gpu/drm/i915/i915_gpu_error.c
drivers/gpu/drm/i915/i915_perf.c
drivers/gpu/drm/i915/i915_query.c
drivers/gpu/drm/i915/intel_device_info.c
drivers/gpu/drm/i915/intel_device_info.h

index 41784df..d0bdb6d 100644 (file)
@@ -1400,11 +1400,12 @@ static int get_ringsize(struct i915_gem_context *ctx,
 }
 
 int
-i915_gem_user_to_context_sseu(struct drm_i915_private *i915,
+i915_gem_user_to_context_sseu(struct intel_gt *gt,
                              const struct drm_i915_gem_context_param_sseu *user,
                              struct intel_sseu *context)
 {
-       const struct sseu_dev_info *device = &RUNTIME_INFO(i915)->sseu;
+       const struct sseu_dev_info *device = &gt->info.sseu;
+       struct drm_i915_private *i915 = gt->i915;
 
        /* No zeros in any field. */
        if (!user->slice_mask || !user->subslice_mask ||
@@ -1537,7 +1538,7 @@ static int set_sseu(struct i915_gem_context *ctx,
                goto out_ce;
        }
 
-       ret = i915_gem_user_to_context_sseu(i915, &user_sseu, &sseu);
+       ret = i915_gem_user_to_context_sseu(ce->engine->gt, &user_sseu, &sseu);
        if (ret)
                goto out_ce;
 
index 3702b2f..a133f92 100644 (file)
@@ -225,7 +225,7 @@ i915_gem_engines_iter_next(struct i915_gem_engines_iter *it);
 struct i915_lut_handle *i915_lut_handle_alloc(void);
 void i915_lut_handle_free(struct i915_lut_handle *lut);
 
-int i915_gem_user_to_context_sseu(struct drm_i915_private *i915,
+int i915_gem_user_to_context_sseu(struct intel_gt *gt,
                                  const struct drm_i915_gem_context_param_sseu *user,
                                  struct intel_sseu *context);
 
index b819788..7ffc3c7 100644 (file)
@@ -1229,7 +1229,7 @@ __igt_ctx_sseu(struct drm_i915_private *i915,
        int inst = 0;
        int ret = 0;
 
-       if (INTEL_GEN(i915) < 9 || !RUNTIME_INFO(i915)->sseu.has_slice_pg)
+       if (INTEL_GEN(i915) < 9)
                return 0;
 
        if (flags & TEST_RESET)
@@ -1255,6 +1255,9 @@ __igt_ctx_sseu(struct drm_i915_private *i915,
                if (hweight32(engine->sseu.slice_mask) < 2)
                        continue;
 
+               if (!engine->gt->info.sseu.has_slice_pg)
+                       continue;
+
                /*
                 * Gen11 VME friendly power-gated configuration with
                 * half enabled sub-slices.
index 27ae480..b9c8163 100644 (file)
@@ -30,7 +30,7 @@ static int gen8_emit_rpcs_config(struct i915_request *rq,
        *cs++ = MI_STORE_DWORD_IMM_GEN4 | MI_USE_GGTT;
        *cs++ = lower_32_bits(offset);
        *cs++ = upper_32_bits(offset);
-       *cs++ = intel_sseu_make_rpcs(rq->engine->i915, &sseu);
+       *cs++ = intel_sseu_make_rpcs(rq->engine->gt, &sseu);
 
        intel_ring_advance(rq, cs);
 
index fca3c23..dd1a42c 100644 (file)
@@ -709,7 +709,7 @@ static int engine_setup_common(struct intel_engine_cs *engine)
 
        /* Use the whole device by default */
        engine->sseu =
-               intel_sseu_from_device_info(&RUNTIME_INFO(engine->i915)->sseu);
+               intel_sseu_from_device_info(&engine->gt->info.sseu);
 
        intel_engine_init_workarounds(engine);
        intel_engine_init_whitelist(engine);
@@ -1075,7 +1075,7 @@ void intel_engine_get_instdone(const struct intel_engine_cs *engine,
                               struct intel_instdone *instdone)
 {
        struct drm_i915_private *i915 = engine->i915;
-       const struct sseu_dev_info *sseu = &RUNTIME_INFO(i915)->sseu;
+       const struct sseu_dev_info *sseu = &engine->gt->info.sseu;
        struct intel_uncore *uncore = engine->uncore;
        u32 mmio_base = engine->mmio_base;
        int slice;
index 2c20fe6..e0755f1 100644 (file)
@@ -655,4 +655,6 @@ void intel_gt_info_print(const struct intel_gt_info *info,
                         struct drm_printer *p)
 {
        drm_printf(p, "available engines: %x\n", info->engine_mask);
+
+       intel_sseu_dump(&info->sseu, p);
 }
index bb75518..6d39a4a 100644 (file)
@@ -116,6 +116,9 @@ struct intel_gt {
 
                /* Media engine access to SFC per instance */
                u8 vdbox_sfc_access;
+
+               /* Slice/subslice/EU info */
+               struct sseu_dev_info sseu;
        } info;
 };
 
index e866b8d..9e28b2f 100644 (file)
@@ -3422,7 +3422,7 @@ __execlists_update_reg_state(const struct intel_context *ce,
        /* RPCS */
        if (engine->class == RENDER_CLASS) {
                regs[CTX_R_PWR_CLK_STATE] =
-                       intel_sseu_make_rpcs(engine->i915, &ce->sseu);
+                       intel_sseu_make_rpcs(engine->gt, &ce->sseu);
 
                i915_oa_init_reg_state(ce, engine);
        }
index 296391d..97ba14a 100644 (file)
@@ -1062,11 +1062,12 @@ static bool gen6_rps_enable(struct intel_rps *rps)
 static int chv_rps_max_freq(struct intel_rps *rps)
 {
        struct drm_i915_private *i915 = rps_to_i915(rps);
+       struct intel_gt *gt = rps_to_gt(rps);
        u32 val;
 
        val = vlv_punit_read(i915, FB_GFX_FMAX_AT_VMAX_FUSE);
 
-       switch (RUNTIME_INFO(i915)->sseu.eu_total) {
+       switch (gt->info.sseu.eu_total) {
        case 8:
                /* (2 * 4) config */
                val >>= FB_GFX_FMAX_AT_VMAX_2SS4EU_FUSE_SHIFT;
index 14c15cc..f1c039e 100644 (file)
@@ -128,7 +128,7 @@ static void gen11_compute_sseu_info(struct sseu_dev_info *sseu,
 
 static void gen12_sseu_info_init(struct intel_gt *gt)
 {
-       struct sseu_dev_info *sseu = &RUNTIME_INFO(gt->i915)->sseu;
+       struct sseu_dev_info *sseu = &gt->info.sseu;
        struct intel_uncore *uncore = gt->uncore;
        u32 dss_en;
        u16 eu_en = 0;
@@ -163,7 +163,7 @@ static void gen12_sseu_info_init(struct intel_gt *gt)
 
 static void gen11_sseu_info_init(struct intel_gt *gt)
 {
-       struct sseu_dev_info *sseu = &RUNTIME_INFO(gt->i915)->sseu;
+       struct sseu_dev_info *sseu = &gt->info.sseu;
        struct intel_uncore *uncore = gt->uncore;
        u32 ss_en;
        u8 eu_en;
@@ -192,7 +192,7 @@ static void gen11_sseu_info_init(struct intel_gt *gt)
 static void gen10_sseu_info_init(struct intel_gt *gt)
 {
        struct intel_uncore *uncore = gt->uncore;
-       struct sseu_dev_info *sseu = &RUNTIME_INFO(gt->i915)->sseu;
+       struct sseu_dev_info *sseu = &gt->info.sseu;
        const u32 fuse2 = intel_uncore_read(uncore, GEN8_FUSE2);
        const int eu_mask = 0xff;
        u32 subslice_mask, eu_en;
@@ -268,7 +268,7 @@ static void gen10_sseu_info_init(struct intel_gt *gt)
 
 static void cherryview_sseu_info_init(struct intel_gt *gt)
 {
-       struct sseu_dev_info *sseu = &RUNTIME_INFO(gt->i915)->sseu;
+       struct sseu_dev_info *sseu = &gt->info.sseu;
        u32 fuse;
        u8 subslice_mask = 0;
 
@@ -325,7 +325,7 @@ static void gen9_sseu_info_init(struct intel_gt *gt)
 {
        struct drm_i915_private *i915 = gt->i915;
        struct intel_device_info *info = mkwrite_device_info(i915);
-       struct sseu_dev_info *sseu = &RUNTIME_INFO(i915)->sseu;
+       struct sseu_dev_info *sseu = &gt->info.sseu;
        struct intel_uncore *uncore = gt->uncore;
        u32 fuse2, eu_disable, subslice_mask;
        const u8 eu_mask = 0xff;
@@ -430,7 +430,7 @@ static void gen9_sseu_info_init(struct intel_gt *gt)
 
 static void bdw_sseu_info_init(struct intel_gt *gt)
 {
-       struct sseu_dev_info *sseu = &RUNTIME_INFO(gt->i915)->sseu;
+       struct sseu_dev_info *sseu = &gt->info.sseu;
        struct intel_uncore *uncore = gt->uncore;
        int s, ss;
        u32 fuse2, subslice_mask, eu_disable[3]; /* s_max */
@@ -516,7 +516,7 @@ static void bdw_sseu_info_init(struct intel_gt *gt)
 static void hsw_sseu_info_init(struct intel_gt *gt)
 {
        struct drm_i915_private *i915 = gt->i915;
-       struct sseu_dev_info *sseu = &RUNTIME_INFO(gt->i915)->sseu;
+       struct sseu_dev_info *sseu = &gt->info.sseu;
        u32 fuse1;
        u8 subslice_mask = 0;
        int s, ss;
@@ -601,10 +601,11 @@ void intel_sseu_info_init(struct intel_gt *gt)
                gen12_sseu_info_init(gt);
 }
 
-u32 intel_sseu_make_rpcs(struct drm_i915_private *i915,
+u32 intel_sseu_make_rpcs(struct intel_gt *gt,
                         const struct intel_sseu *req_sseu)
 {
-       const struct sseu_dev_info *sseu = &RUNTIME_INFO(i915)->sseu;
+       struct drm_i915_private *i915 = gt->i915;
+       const struct sseu_dev_info *sseu = &gt->info.sseu;
        bool subslice_pg = sseu->has_subslice_pg;
        u8 slices, subslices;
        u32 rpcs = 0;
index f9c007f..23ba6c2 100644 (file)
@@ -98,7 +98,7 @@ void intel_sseu_set_subslices(struct sseu_dev_info *sseu, int slice,
 
 void intel_sseu_info_init(struct intel_gt *gt);
 
-u32 intel_sseu_make_rpcs(struct drm_i915_private *i915,
+u32 intel_sseu_make_rpcs(struct intel_gt *gt,
                         const struct intel_sseu *req_sseu);
 
 void intel_sseu_dump(const struct sseu_dev_info *sseu, struct drm_printer *p);
index 2da3668..dbafd92 100644 (file)
@@ -404,7 +404,7 @@ static void gen9_ctx_workarounds_init(struct intel_engine_cs *engine,
 static void skl_tune_iz_hashing(struct intel_engine_cs *engine,
                                struct i915_wa_list *wal)
 {
-       struct drm_i915_private *i915 = engine->i915;
+       struct intel_gt *gt = engine->gt;
        u8 vals[3] = { 0, 0, 0 };
        unsigned int i;
 
@@ -415,7 +415,7 @@ static void skl_tune_iz_hashing(struct intel_engine_cs *engine,
                 * Only consider slices where one, and only one, subslice has 7
                 * EUs
                 */
-               if (!is_power_of_2(RUNTIME_INFO(i915)->sseu.subslice_7eu[i]))
+               if (!is_power_of_2(gt->info.sseu.subslice_7eu[i]))
                        continue;
 
                /*
@@ -424,7 +424,7 @@ static void skl_tune_iz_hashing(struct intel_engine_cs *engine,
                 *
                 * ->    0 <= ss <= 3;
                 */
-               ss = ffs(RUNTIME_INFO(i915)->sseu.subslice_7eu[i]) - 1;
+               ss = ffs(gt->info.sseu.subslice_7eu[i]) - 1;
                vals[i] = 3 - ss;
        }
 
@@ -1036,7 +1036,7 @@ cfl_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
 static void
 wa_init_mcr(struct drm_i915_private *i915, struct i915_wa_list *wal)
 {
-       const struct sseu_dev_info *sseu = &RUNTIME_INFO(i915)->sseu;
+       const struct sseu_dev_info *sseu = &i915->gt.info.sseu;
        unsigned int slice, subslice;
        u32 l3_en, mcr, mcr_mask;
 
index c10ae16..d440610 100644 (file)
@@ -68,7 +68,6 @@ struct __guc_ads_blob {
 static void __guc_ads_init(struct intel_guc *guc)
 {
        struct intel_gt *gt = guc_to_gt(guc);
-       struct drm_i915_private *dev_priv = gt->i915;
        struct __guc_ads_blob *blob = guc->ads_blob;
        const u32 skipped_size = LRC_PPHWSP_SZ * PAGE_SIZE + LR_HW_CONTEXT_SIZE;
        u32 base;
@@ -100,7 +99,7 @@ static void __guc_ads_init(struct intel_guc *guc)
        }
 
        /* System info */
-       blob->system_info.slice_enabled = hweight8(RUNTIME_INFO(dev_priv)->sseu.slice_mask);
+       blob->system_info.slice_enabled = hweight8(gt->info.sseu.slice_mask);
        blob->system_info.rcs_enabled = 1;
        blob->system_info.bcs_enabled = 1;
 
index bfba0df..69acc69 100644 (file)
@@ -1327,7 +1327,7 @@ static int i915_rcs_topology(struct seq_file *m, void *unused)
        struct drm_i915_private *dev_priv = node_to_i915(m->private);
        struct drm_printer p = drm_seq_file_printer(m);
 
-       intel_sseu_print_topology(&RUNTIME_INFO(dev_priv)->sseu, &p);
+       intel_sseu_print_topology(&dev_priv->gt.info.sseu, &p);
 
        return 0;
 }
@@ -1628,7 +1628,7 @@ static void gen10_sseu_device_status(struct drm_i915_private *dev_priv,
                                     struct sseu_dev_info *sseu)
 {
 #define SS_MAX 6
-       const struct intel_runtime_info *info = RUNTIME_INFO(dev_priv);
+       const struct intel_gt_info *info = &dev_priv->gt.info;
        u32 s_reg[SS_MAX], eu_reg[2 * SS_MAX], eu_mask[2];
        int s, ss;
 
@@ -1685,7 +1685,7 @@ static void gen9_sseu_device_status(struct drm_i915_private *dev_priv,
                                    struct sseu_dev_info *sseu)
 {
 #define SS_MAX 3
-       const struct intel_runtime_info *info = RUNTIME_INFO(dev_priv);
+       const struct intel_gt_info *info = &dev_priv->gt.info;
        u32 s_reg[SS_MAX], eu_reg[2 * SS_MAX], eu_mask[2];
        int s, ss;
 
@@ -1743,7 +1743,7 @@ static void gen9_sseu_device_status(struct drm_i915_private *dev_priv,
 static void bdw_sseu_device_status(struct drm_i915_private *dev_priv,
                                   struct sseu_dev_info *sseu)
 {
-       const struct intel_runtime_info *info = RUNTIME_INFO(dev_priv);
+       const struct intel_gt_info *info = &dev_priv->gt.info;
        u32 slice_info = I915_READ(GEN8_GT_SLICE_INFO);
        int s;
 
@@ -1806,7 +1806,7 @@ static void i915_print_sseu_info(struct seq_file *m, bool is_available_info,
 static int i915_sseu_status(struct seq_file *m, void *unused)
 {
        struct drm_i915_private *dev_priv = node_to_i915(m->private);
-       const struct intel_runtime_info *info = RUNTIME_INFO(dev_priv);
+       const struct intel_gt_info *info = &dev_priv->gt.info;
        struct sseu_dev_info sseu;
        intel_wakeref_t wakeref;
 
index 40390b2..4216132 100644 (file)
@@ -12,7 +12,7 @@ int i915_getparam_ioctl(struct drm_device *dev, void *data,
                        struct drm_file *file_priv)
 {
        struct drm_i915_private *i915 = to_i915(dev);
-       const struct sseu_dev_info *sseu = &RUNTIME_INFO(i915)->sseu;
+       const struct sseu_dev_info *sseu = &i915->gt.info.sseu;
        drm_i915_getparam_t *param = data;
        int value;
 
index 99b4a02..678ddec 100644 (file)
@@ -426,7 +426,7 @@ static void err_compression_marker(struct drm_i915_error_state_buf *m)
 static void error_print_instdone(struct drm_i915_error_state_buf *m,
                                 const struct intel_engine_coredump *ee)
 {
-       const struct sseu_dev_info *sseu = &RUNTIME_INFO(m->i915)->sseu;
+       const struct sseu_dev_info *sseu = &ee->engine->gt->info.sseu;
        int slice;
        int subslice;
 
@@ -626,8 +626,8 @@ static void err_print_capabilities(struct drm_i915_error_state_buf *m,
 
        intel_device_info_print_static(&error->device_info, &p);
        intel_device_info_print_runtime(&error->runtime_info, &p);
-       intel_sseu_print_topology(&error->runtime_info.sseu, &p);
        intel_gt_info_print(&error->gt->info, &p);
+       intel_sseu_print_topology(&error->gt->info.sseu, &p);
        intel_driver_caps_print(&error->driver_caps, &p);
 }
 
index 25329b7..37631ce 100644 (file)
@@ -2196,7 +2196,7 @@ static int gen8_configure_context(struct i915_gem_context *ctx,
                if (!intel_context_pin_if_active(ce))
                        continue;
 
-               flex->value = intel_sseu_make_rpcs(ctx->i915, &ce->sseu);
+               flex->value = intel_sseu_make_rpcs(ce->engine->gt, &ce->sseu);
                err = gen8_modify_context(ce, flex, count);
 
                intel_context_unpin(ce);
@@ -2340,7 +2340,7 @@ oa_configure_all_contexts(struct i915_perf_stream *stream,
                if (engine->class != RENDER_CLASS)
                        continue;
 
-               regs[0].value = intel_sseu_make_rpcs(i915, &ce->sseu);
+               regs[0].value = intel_sseu_make_rpcs(engine->gt, &ce->sseu);
 
                err = gen8_modify_self(ce, regs, num_regs, active);
                if (err)
@@ -2740,8 +2740,7 @@ static void
 get_default_sseu_config(struct intel_sseu *out_sseu,
                        struct intel_engine_cs *engine)
 {
-       const struct sseu_dev_info *devinfo_sseu =
-               &RUNTIME_INFO(engine->i915)->sseu;
+       const struct sseu_dev_info *devinfo_sseu = &engine->gt->info.sseu;
 
        *out_sseu = intel_sseu_from_device_info(devinfo_sseu);
 
@@ -2766,7 +2765,7 @@ get_sseu_config(struct intel_sseu *out_sseu,
            drm_sseu->engine.engine_instance != engine->uabi_instance)
                return -EINVAL;
 
-       return i915_gem_user_to_context_sseu(engine->i915, drm_sseu, out_sseu);
+       return i915_gem_user_to_context_sseu(engine->gt, drm_sseu, out_sseu);
 }
 
 /**
index c1ebda9..fed337a 100644 (file)
@@ -31,7 +31,7 @@ static int copy_query_item(void *query_hdr, size_t query_sz,
 static int query_topology_info(struct drm_i915_private *dev_priv,
                               struct drm_i915_query_item *query_item)
 {
-       const struct sseu_dev_info *sseu = &RUNTIME_INFO(dev_priv)->sseu;
+       const struct sseu_dev_info *sseu = &dev_priv->gt.info.sseu;
        struct drm_i915_query_topology_info topo;
        u32 slice_length, subslice_length, eu_length, total_length;
        int ret;
index d8daf22..3f5dc37 100644 (file)
@@ -29,7 +29,6 @@
 #include "display/intel_de.h"
 #include "intel_device_info.h"
 #include "i915_drv.h"
-#include "gt/intel_sseu.h"
 
 #define PLATFORM_NAME(x) [INTEL_##x] = #x
 static const char * const platform_names[] = {
@@ -115,8 +114,6 @@ void intel_device_info_print_static(const struct intel_device_info *info,
 void intel_device_info_print_runtime(const struct intel_runtime_info *info,
                                     struct drm_printer *p)
 {
-       intel_sseu_dump(&info->sseu, p);
-
        drm_printf(p, "rawclk rate: %u kHz\n", info->rawclk_freq);
        drm_printf(p, "CS timestamp frequency: %u Hz\n",
                   info->cs_timestamp_frequency_hz);
index 40057ab..242d008 100644 (file)
@@ -219,9 +219,6 @@ struct intel_runtime_info {
        u8 num_sprites[I915_MAX_PIPES];
        u8 num_scalers[I915_MAX_PIPES];
 
-       /* Slice/subslice/EU info */
-       struct sseu_dev_info sseu;
-
        u32 rawclk_freq;
 
        u32 cs_timestamp_frequency_hz;