USB: appledisplay.c: remove dbg() usage
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 2 May 2012 04:33:54 +0000 (21:33 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 2 May 2012 04:33:54 +0000 (21:33 -0700)
dbg() was a very old USB-specific macro that should no longer
be used. This patch removes it from being used in the driver
and uses dev_dbg() instead.

CC: Andrew Morton <akpm@linux-foundation.org>
CC: Eric Dumazet <eric.dumazet@gmail.com>
CC: Mike Frysinger <vapier@gentoo.org>
CC: Arun Sharma <asharma@fb.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/misc/appledisplay.c

index ac0d75a..0fc6e5f 100644 (file)
@@ -88,6 +88,7 @@ static struct workqueue_struct *wq;
 static void appledisplay_complete(struct urb *urb)
 {
        struct appledisplay *pdata = urb->context;
+       struct device *dev = &pdata->udev->dev;
        unsigned long flags;
        int status = urb->status;
        int retval;
@@ -97,18 +98,18 @@ static void appledisplay_complete(struct urb *urb)
                /* success */
                break;
        case -EOVERFLOW:
-               printk(KERN_ERR "appletouch: OVERFLOW with data "
-                       "length %d, actual length is %d\n",
+               dev_err(dev,
+                       "OVERFLOW with data length %d, actual length is %d\n",
                        ACD_URB_BUFFER_LEN, pdata->urb->actual_length);
        case -ECONNRESET:
        case -ENOENT:
        case -ESHUTDOWN:
                /* This urb is terminated, clean up */
-               dbg("%s - urb shuttingdown with status: %d",
+               dev_dbg(dev, "%s - urb shuttingdown with status: %d\n",
                        __func__, status);
                return;
        default:
-               dbg("%s - nonzero urb status received: %d",
+               dev_dbg(dev, "%s - nonzero urb status received: %d/n",
                        __func__, status);
                goto exit;
        }
@@ -132,8 +133,7 @@ static void appledisplay_complete(struct urb *urb)
 exit:
        retval = usb_submit_urb(pdata->urb, GFP_ATOMIC);
        if (retval) {
-               dev_err(&pdata->udev->dev,
-                       "%s - usb_submit_urb failed with result %d\n",
+               dev_err(dev, "%s - usb_submit_urb failed with result %d\n",
                        __func__, retval);
        }
 }