net: 802: psnap.c: Use built-in RCU list checking
authorMadhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
Fri, 21 Feb 2020 16:19:47 +0000 (21:49 +0530)
committerDavid S. Miller <davem@davemloft.net>
Mon, 24 Feb 2020 21:02:53 +0000 (13:02 -0800)
list_for_each_entry_rcu() has built-in RCU and lock checking.

Pass cond argument to list_for_each_entry_rcu() to silence
false lockdep warning when CONFIG_PROVE_RCU_LIST is enabled
by default.

Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/802/psnap.c

index 40ab2ae..4492e8d 100644 (file)
@@ -30,7 +30,7 @@ static struct datalink_proto *find_snap_client(const unsigned char *desc)
 {
        struct datalink_proto *proto = NULL, *p;
 
-       list_for_each_entry_rcu(p, &snap_list, node) {
+       list_for_each_entry_rcu(p, &snap_list, node, lockdep_is_held(&snap_lock)) {
                if (!memcmp(p->type, desc, 5)) {
                        proto = p;
                        break;