iwlwifi: yoyo: remove magic number
authorMordechay Goodstein <mordechay.goodstein@intel.com>
Fri, 24 Apr 2020 16:46:59 +0000 (19:46 +0300)
committerLuca Coelho <luciano.coelho@intel.com>
Fri, 8 May 2020 06:51:49 +0000 (09:51 +0300)
The for loop is iterating over active regions so iterate only
over the len of the active regions buffer size.

Signed-off-by: Mordechay Goodstein <mordechay.goodstein@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20200424194456.e10482b9eed7.I15da7bb25d9b9e3eef1c1b117dc585e703ce756a@changeid
drivers/net/wireless/intel/iwlwifi/fw/dbg.c

index 4df10f3..04de768 100644 (file)
@@ -2119,7 +2119,11 @@ static u32 iwl_dump_ini_trigger(struct iwl_fw_runtime *fwrt,
        u32 size = 0;
        u64 regions_mask = le64_to_cpu(trigger->regions_mask);
 
-       for (i = 0; i < 64; i++) {
+       BUILD_BUG_ON(sizeof(trigger->regions_mask) != sizeof(regions_mask));
+       BUILD_BUG_ON((sizeof(trigger->regions_mask) * BITS_PER_BYTE) <
+                    ARRAY_SIZE(fwrt->trans->dbg.active_regions));
+
+       for (i = 0; i < ARRAY_SIZE(fwrt->trans->dbg.active_regions); i++) {
                u32 reg_type;
                struct iwl_fw_ini_region_tlv *reg;