net: ethernet: ti: am65-cpsw: use return instead of goto in am65_cpsw_run_xdp()
authorRoger Quadros <rogerq@kernel.org>
Mon, 17 Feb 2025 07:31:48 +0000 (09:31 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 19 Feb 2025 11:52:44 +0000 (11:52 +0000)
In am65_cpsw_run_xdp() instead of goto followed by return, simply return.

Signed-off-by: Roger Quadros <rogerq@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ti/am65-cpsw-nuss.c

index 1348020..e1d7c3b 100644 (file)
@@ -1193,8 +1193,7 @@ static int am65_cpsw_run_xdp(struct am65_cpsw_rx_flow *flow,
 
        switch (act) {
        case XDP_PASS:
-               ret = AM65_CPSW_XDP_PASS;
-               goto out;
+               return AM65_CPSW_XDP_PASS;
        case XDP_TX:
                tx_chn = &common->tx_chns[cpu % AM65_CPSW_MAX_QUEUES];
                netif_txq = netdev_get_tx_queue(ndev, tx_chn->id);
@@ -1213,15 +1212,13 @@ static int am65_cpsw_run_xdp(struct am65_cpsw_rx_flow *flow,
                        goto drop;
 
                dev_sw_netstats_rx_add(ndev, pkt_len);
-               ret = AM65_CPSW_XDP_CONSUMED;
-               goto out;
+               return AM65_CPSW_XDP_CONSUMED;
        case XDP_REDIRECT:
                if (unlikely(xdp_do_redirect(ndev, xdp, prog)))
                        goto drop;
 
                dev_sw_netstats_rx_add(ndev, pkt_len);
-               ret = AM65_CPSW_XDP_REDIRECT;
-               goto out;
+               return AM65_CPSW_XDP_REDIRECT;
        default:
                bpf_warn_invalid_xdp_action(ndev, prog, act);
                fallthrough;
@@ -1236,7 +1233,6 @@ drop:
        page = virt_to_head_page(xdp->data);
        am65_cpsw_put_page(flow, page, true);
 
-out:
        return ret;
 }