iio: dac: ltc2688: make use of regmap_set_bits()
authorTrevor Gamblin <tgamblin@baylibre.com>
Mon, 17 Jun 2024 13:49:59 +0000 (09:49 -0400)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Tue, 25 Jun 2024 20:04:46 +0000 (21:04 +0100)
Instead of using regmap_update_bits() and passing the mask twice, use
regmap_set_bits().

Suggested-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Link: https://patch.msgid.link/20240617-review-v3-19-88d1338c4cca@baylibre.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/dac/ltc2688.c

index c4b1ba3..af50d2a 100644 (file)
@@ -860,9 +860,8 @@ static int ltc2688_setup(struct ltc2688_state *st, struct regulator *vref)
                /* bring device out of reset */
                gpiod_set_value_cansleep(gpio, 0);
        } else {
-               ret = regmap_update_bits(st->regmap, LTC2688_CMD_CONFIG,
-                                        LTC2688_CONFIG_RST,
-                                        LTC2688_CONFIG_RST);
+               ret = regmap_set_bits(st->regmap, LTC2688_CMD_CONFIG,
+                                     LTC2688_CONFIG_RST);
                if (ret)
                        return ret;
        }