mtd: ubi: fix unreleased fwnode_handle in find_volume_fwnode()
authorJavier Carrasco <javier.carrasco.cruz@gmail.com>
Sat, 19 Oct 2024 20:27:03 +0000 (22:27 +0200)
committerRichard Weinberger <richard@nod.at>
Thu, 14 Nov 2024 18:52:14 +0000 (19:52 +0100)
The 'fw_vols' fwnode_handle initialized via
device_get_named_child_node() requires explicit calls to
fwnode_handle_put() when the variable is no longer required.

Add the missing calls to fwnode_handle_put() before the function
returns.

Cc: stable@vger.kernel.org
Fixes: 51932f9fc487 ("mtd: ubi: populate ubi volume fwnode")
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
drivers/mtd/ubi/vmt.c

index 5a3558b..e5cf3bd 100644 (file)
@@ -143,8 +143,10 @@ static struct fwnode_handle *find_volume_fwnode(struct ubi_volume *vol)
                    vol->vol_id != volid)
                        continue;
 
+               fwnode_handle_put(fw_vols);
                return fw_vol;
        }
+       fwnode_handle_put(fw_vols);
 
        return NULL;
 }