drm/amd/powerplay: delete some dead code
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 21 Mar 2019 06:27:07 +0000 (09:27 +0300)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 21 Mar 2019 19:05:26 +0000 (14:05 -0500)
The "size" variable is unsigned.  We never pass invalid sizes to this
function and we already used it as an array offset earlier so it's
too late to check here.

Reviewed-by: Huang Rui <ray.huang@amd.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/powerplay/smu_v11_0.c

index 026bebe..9d75911 100644 (file)
@@ -1668,9 +1668,6 @@ static int smu_v11_0_set_power_profile_mode(struct smu_context *smu, long *input
        }
 
        if (smu->power_profile_mode == PP_SMC_POWER_PROFILE_CUSTOM) {
-               if (size < 0)
-                       return -EINVAL;
-
                ret = smu_v11_0_get_activity_monitor_coeff(smu,
                                                           (uint8_t *)(&activity_monitor),
                                                           WORKLOAD_PPLIB_CUSTOM_BIT);