media: mali-c55: Bypass Purple Fringe Correction
authorJacopo Mondi <jacopo.mondi@ideasonboard.com>
Wed, 11 Mar 2026 11:29:32 +0000 (12:29 +0100)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Tue, 24 Mar 2026 15:13:09 +0000 (16:13 +0100)
The Purple Fringe Correction module is enabled by default with a POR
configuration which might not be correct for the lens/sensor combination
in use.

If the Purple Fringe Correction module has to be used, it needs to be
supported in the driver's uAPI and properly configured by userspace.

As the driver doesn't support it at the moment, bypass it by default.

Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/platform/arm/mali-c55/mali-c55-params.c

index b9fc904..de0e9d8 100644 (file)
@@ -830,9 +830,10 @@ void mali_c55_params_init_isp_config(struct mali_c55 *mali_c55,
                                 MALI_C55_REG_BYPASS_3_IRIDIX,
                                 MALI_C55_REG_BYPASS_3_IRIDIX);
 
-       /* Bypass the colour noise reduction  */
+       /* Bypass the colour noise reduction and the PF modules  */
        mali_c55_ctx_write(mali_c55, MALI_C55_REG_BYPASS_4,
-                          MALI_C55_REG_BYPASS_4_CNR);
+                          MALI_C55_REG_BYPASS_4_CNR |
+                          MALI_C55_REG_BYPASS_4_PF_CORRECTION);
 
        /* Disable the sinter module */
        mali_c55_ctx_update_bits(mali_c55, MALI_C55_REG_SINTER_CONFIG,