x86/sev: Remove duplicated assignment to variable info
authorColin Ian King <colin.i.king@gmail.com>
Mon, 16 May 2022 18:42:15 +0000 (19:42 +0100)
committerBorislav Petkov <bp@suse.de>
Tue, 17 May 2022 10:52:37 +0000 (12:52 +0200)
Variable info is being assigned the same value twice, remove the
redundant assignment. Also assign variable v in the declaration.

Cleans up clang scan warning:
  warning: Value stored to 'info' during its initialization is never read [deadcode.DeadStores]

No code changed:

  # arch/x86/kernel/sev.o:

   text    data     bss     dec     hex filename
  19878    4487    4112   28477    6f3d sev.o.before
  19878    4487    4112   28477    6f3d sev.o.after

md5:
   bfbaa515af818615fd01fea91e7eba1b  sev.o.before.asm
   bfbaa515af818615fd01fea91e7eba1b  sev.o.after.asm

  [ bp: Running the before/after check on sev.c because sev-shared.c
    gets included into it. ]

Fixes: 597cfe48212a ("x86/boot/compressed/64: Setup a GHCB-based VC Exception handler")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lore.kernel.org/r/20220516184215.51841-1-colin.i.king@gmail.com
arch/x86/kernel/sev-shared.c

index 2b4270d..b478edf 100644 (file)
@@ -201,10 +201,7 @@ static enum es_result verify_exception_info(struct ghcb *ghcb, struct es_em_ctxt
 
        if (ret == 1) {
                u64 info = ghcb->save.sw_exit_info_2;
-               unsigned long v;
-
-               info = ghcb->save.sw_exit_info_2;
-               v = info & SVM_EVTINJ_VEC_MASK;
+               unsigned long v = info & SVM_EVTINJ_VEC_MASK;
 
                /* Check if exception information from hypervisor is sane. */
                if ((info & SVM_EVTINJ_VALID) &&