drm/amd/powerplay: drop unnecessary message support check(v2)
authorChangfeng <Changfeng.Zhu@amd.com>
Fri, 24 Jul 2020 05:15:10 +0000 (13:15 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 27 Jul 2020 20:21:58 +0000 (16:21 -0400)
Take back patch:drop unnecessary message support check
Because the gpu reset fail problem on renoir can be fixed by:
drm/amd/powerplay: skip invalid msg when smu set mp1 state
It needs to remove SWSMU_CODE_LAYER_L1 in smu_cmn.h to guard a clear
code layer.

Signed-off-by: changfeng <Changfeng.Zhu@amd.com>
Reviewed-by: Evan Quan <evan.quan@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
drivers/gpu/drm/amd/powerplay/smu_cmn.h

index 7d9c40a..3b427fa 100644 (file)
@@ -34,7 +34,6 @@
 #include "sienna_cichlid_ppt.h"
 #include "renoir_ppt.h"
 #include "amd_pcie.h"
-#include "smu_cmn.h"
 
 /*
  * DO NOT use these for err/warn/info/debug messages.
@@ -1591,14 +1590,6 @@ int smu_set_mp1_state(struct smu_context *smu,
                return 0;
        }
 
-       /* some asics may not support those messages */
-       if (smu_cmn_to_asic_specific_index(smu,
-                                          CMN2ASIC_MAPPING_MSG,
-                                          msg) < 0) {
-               mutex_unlock(&smu->mutex);
-               return 0;
-       }
-
        ret = smu_send_smc_msg(smu, msg, NULL);
        /* some asics may not support those messages */
        if (ret == -EINVAL)
index f9e63f1..98face8 100644 (file)
@@ -25,7 +25,7 @@
 
 #include "amdgpu_smu.h"
 
-#if defined(SWSMU_CODE_LAYER_L1) || defined(SWSMU_CODE_LAYER_L2) || defined(SWSMU_CODE_LAYER_L3) || defined(SWSMU_CODE_LAYER_L4)
+#if defined(SWSMU_CODE_LAYER_L2) || defined(SWSMU_CODE_LAYER_L3) || defined(SWSMU_CODE_LAYER_L4)
 int smu_cmn_send_smc_msg_with_param(struct smu_context *smu,
                                    enum smu_message_type msg,
                                    uint32_t param,